Re: [PATCH] pci: Use bool return type for some virPCIDeviceGet*() functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-01-28 at 10:35 -0500, John Ferlan wrote:
> 
> On 01/28/2016 03:21 AM, Andrea Bolognani wrote:
> > The affected functions are:
> > 
> >   virPCIDeviceGetManaged()
> >   virPCIDeviceGetUnbindFromStub()
> >   virPCIDeviceGetRemoveSlot()
> >   virPCIDeviceGetReprobe()
> > 
> > Change their return type from unsigned int to bool: the corresponding
> > members in struct _virPCIDevice are defined as bool, and even the
> > corresponding virPCIDeviceSet*() functions take a bool value as input
> > so there's no point in these functions having unsigned int as return
> > type.
> > 
> > Suggested-by: John Ferlan <jferlan@xxxxxxxxxx>
> > ---
> >  src/util/virpci.c | 8 ++++----
> >  src/util/virpci.h | 8 ++++----
> >  2 files changed, 8 insertions(+), 8 deletions(-)
> > 
> 
> ACK

Pushed, thanks.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]