[PATCH v3 0/4] virshBlockJobWait improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



v2 discussion at:

  http://www.redhat.com/archives/libvir-list/2016-January/msg01063.html

As requested I've split this into separate commits. All of the comment
nitpicks have been applied.

With regards to using "break" or "goto cleanup" to exit the loop, I decided
to use "goto" on all the error cases and "break" everywhere else. I had
noticed another bug where the SIGINT signal action wasn't reset if the
virTimeMillisNow() call failed; that's fixed in patch 3 in this series.

Michael Chapman (4):
  virsh: avoid unnecessary progress updates
  virsh: be consistent with style of loop exit
  virsh: ensure SIGINT action is reset on all errors
  virsh: improve waiting for block job readiness

 tools/virsh-domain.c | 65 ++++++++++++++++++++++++++++++----------------------
 1 file changed, 37 insertions(+), 28 deletions(-)

-- 
2.4.3

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]