[PATCH RFC 0/2] conf: add net device prefix capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

Back in the pre 1.3.0 release [0] we had a regression when migrating
domains in libxl (introduced by the reverted commit d2e5538b1).
The chosen solution to address this problem was to introduce a
capability to be used by the virDomainNetDefFormat() and
virDomainNetDefParseXML() routines. This series implements this,
and I would ask if it's in line with what you had in mind by
exposing as a hypervisor capability?

For the purposes of RFC and compability with other drivers I left
the hardcoded checking of VIR_NET_GENERATED_PREFIX plus checking a
prefix registered by the driver.

Having this series and the reverted commit applied, I can
successfully migrate a domain without seeing the same interface
name on both source and destination node.

Thoughts?

Thanks!
Joao

[0] https://www.redhat.com/archives/libvir-list/2015-December/msg00279.html

Joao Martins (2):
  conf: add net device prefix to capabilities
  libxl: set net device prefix

 src/conf/capabilities.c     | 21 +++++++++++++++++++++
 src/conf/capabilities.h     |  4 ++++
 src/conf/domain_conf.c      | 20 +++++++++++++++-----
 src/conf/domain_conf.h      |  2 ++
 src/libvirt_private.syms    |  1 +
 src/libxl/libxl_conf.c      |  3 +++
 src/libxl/libxl_conf.h      |  4 ++++
 src/network/bridge_driver.c |  2 +-
 8 files changed, 51 insertions(+), 6 deletions(-)

-- 
2.1.4

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]