On Tue, Jan 19, 2016 at 05:57:17PM +0000, Richard W.M. Jones wrote: > But I think I should test `check_for_errors' instead, since that flag > basically means did we come from the guestfs_shutdown method -- where > we want to be careful about data integrity -- or did we come from the > guestfs_close method -- where the user just wants to close the > connection without caring about data integrity. Actually let me revise that: Even if check_for_errors is NOT set, we still want to wait for qemu to shut down, since we should still do a best effort attempt at data integrity. I'm going to push this without the flags or check_for_errors check. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list