On Tue, Jan 19, 2016 at 10:54:00AM +0100, Ján Tomko wrote: > We either use the value from the environment variable, or learn it from > the existing lease file. > > In the second case, the pointer would be pointing into the JSON object > of the first lease with a DUID, owned by leases_array, then > leases_array_new. > > Always allocate the string instead, making obvious who should free the > string. > --- > src/network/leaseshelper.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) ACK > Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list