Re: [PATCH 4/7] Add new cgroup thread type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 14, 2016 at 01:27:59PM +0300, Alexander Burluka wrote:
> Signed-off-by: Alexander Burluka <aburluka@xxxxxxxxxxxxx>
> ---
>  src/util/vircgroup.c | 4 ++++
>  src/util/vircgroup.h | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
> index 78f519c..b829794 100644
> --- a/src/util/vircgroup.c
> +++ b/src/util/vircgroup.c
> @@ -1514,6 +1514,10 @@ virCgroupNewThread(virCgroupPtr domain,
>          if (virAsprintf(&name, "iothread%d", id) < 0)
>              goto cleanup;
>          break;
> +    case VIR_CGROUP_THREAD_GLOBAL:
> +        if (VIR_STRDUP(name, "") < 0)
> +            goto cleanup;
> +        break;
>      case VIR_CGROUP_THREAD_LAST:
>          virReportError(VIR_ERR_INTERNAL_ERROR,
>                         _("unexpected name value %d"), nameval);
> diff --git a/src/util/vircgroup.h b/src/util/vircgroup.h
> index 63a9e1c..8ee1dad 100644
> --- a/src/util/vircgroup.h
> +++ b/src/util/vircgroup.h
> @@ -56,6 +56,7 @@ typedef enum {
>      VIR_CGROUP_THREAD_VCPU = 0,
>      VIR_CGROUP_THREAD_EMULATOR,
>      VIR_CGROUP_THREAD_IOTHREAD,
> +    VIR_CGROUP_THREAD_GLOBAL,
>  
>      VIR_CGROUP_THREAD_LAST
>  } virCgroupThreadName;
> --

I'm not seeing any point in this. Just use the main top level virCgroupPtr
object we already have for the VM.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]