On Tue, Jan 12, 2016 at 10:53:03AM +0100, Andrea Bolognani wrote: > On Tue, 2016-01-12 at 10:41 +0100, Pavel Hrdina wrote: > > > > Just a question, I know it's to late to change those patches, it's pushed now, > > but why don't we unify the help string for all the commands? It does the same > > thing for all commands, there is no reason to have different help string for > > some commands. And I don't think, that it would break anything. > > The most commonly used help text is "affect next boot", while eg. the > help text for the 'schedinfo' command is "get/set value to be used on > next boot". > > In this case it makes sense to have a different help text, because > the information can not only be set but also retrieved. Yes, that's true and the "affect next boot" is confusing in this case. > > That said, if you can come up with a help text that can accurately > describe all situations where the 'config' option is used, I would > certainly not oppose it :) What about "affect offline definition", for live "affect running definition" and for current "affect current definition"? What each command does is under "DESCRIPTION" and there is no need to repeat that information for each option. > > Cheers. > > -- > Andrea Bolognani > Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list