On Mon, 2016-01-11 at 18:03 -0500, John Ferlan wrote: > I've also lift/applied the "helpstr" to each of the # define > VIRSH_COMMON_OPT_*'s in virsh.h (meaning virsh.h is not included in > po/POTFILES.in either). That also picks up a couple more domain options > from virsh-domain.c which use different helpstr's. What's the advantage of doing so? Now we have two separate, identical definitions for eg. VIRSH_COMMON_OPT_DOMAIN_FULL... > > Is there any actual difference between VSH_OT_STRING and > > VSH_OT_DATA? Can we convert this to VSH_OT_DATA and rename it to > > VIRSH_COMMON_OPT_POOL_OPTIONAL or something like that? Or maybe > > have *this* as VIRSH_COMMON_OPT_POOL and rename the one > > describing a required option to VIRSH_COMMON_OPT_POOL_REQ? > > OT_DATA and OT_STRING are handled differently... STRING is never > OFLAG_REQ and DATA is always OFLAG_REQ. Right. I always forget that :( Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list