Re: [PATCH v3 09/14] virsh: Create macros for common "pool" options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-01-12 at 09:28 +0100, Ján Tomko wrote:
> 
> > > +#define VIRSH_COMMON_OPT_VOLUME_POOL_CREATE                \
> > > +    {.name = "pool",                                       \
> > > +     .type = VSH_OT_DATA,                                  \
> > > +     .flags = VSH_OFLAG_REQ,                               \
> > > +     .help = N_("pool name")                               \
> > > +    }                                                      \
> > 
> > So this is basically the same as VIRSH_COMMON_OPT_POOL, minus "or
> > uuid" in the help text.
> > 
> > Can we get away with just using VIRSH_COMMON_OPT_POOL, relying on
> > the fact that you obviously can't specify the UUID of a yet to be
> > created pool?
> 
> No.

Don't worry, John went with VIRSH_COMMON_OPT_POOL_NAME after all.

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]