Justin Clift wrote: > On 12 Jan 2016, at 01:32, Daniel Veillard <veillard@xxxxxxxxxx> wrote: > > As suggested this w.e., I just tagged the release candidate 1 in git > > and pushed signed tarball and rpms to the usual place: > > > > ftp://libvirt.org/libvirt/ > > > > This works fine with my limited testing, but obviously more people > > need to give it some trial especially on other platforms. > > The output from CentOS CI is mostly green which is a good sign > > with just libvirt-daemon-rpm and virt-manager-test in the red, someone > > probably need to have a look before we release. > > > > The rc2 should come in 2 days on Thursday, and unless there is > > some blocker I plan to push 1.3.1 over the week-end, > > Weirdly, it fails on OSX with the same error: > > ******************************************************************** > > Last 15 lines from /Users/jc/Library/Logs/Homebrew/libvirt/02.make: > CCLD libvirt_driver_vbox.la > CCLD libvirt_driver_storage.la > Undefined symbols for architecture x86_64: > "_xdr_uint64_t", referenced from: > _xdr_virLogManagerProtocolLogFilePosition in virtlogd-log_protocol.o > _xdr_virLogManagerProtocolDomainOpenLogFileRet in virtlogd-log_protocol.o > _xdr_virLogManagerProtocolDomainGetLogFilePositionRet in virtlogd-log_protocol.o > _xdr_virLogManagerProtocolDomainReadLogFileArgs in virtlogd-log_protocol.o > ld: symbol(s) not found for architecture x86_64 > clang: error: linker command failed with exit code 1 (use -v to see invocation) > make[3]: *** [virtlogd] Error 1 > make[3]: *** Waiting for unfinished jobs.... > make[2]: *** [all] Error 2 > make[1]: *** [all-recursive] Error 1 > make: *** [all] Error 2 > > ******************************************************************** > > Was Roman's patch definitely pushed? Oops, it's my fault, I forgot to add the proper include for log protocol. Could you please try the attached patch? If you report it works I'll push it tomorrow as trivial if nobody has objections, it'd be good to have 1.3.1 working on OS X. Roman Bogorodskiy
diff --git a/src/logging/log_protocol.x b/src/logging/log_protocol.x index a07334f..b0ac31b 100644 --- a/src/logging/log_protocol.x +++ b/src/logging/log_protocol.x @@ -2,6 +2,7 @@ */ %#include "internal.h" +%#include "virxdrdefs.h" typedef opaque virLogManagerProtocolUUID[VIR_UUID_BUFLEN];
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list