2016-01-11 17:03 GMT+01:00 Martin Kletzander <mkletzan@xxxxxxxxxx>: > On Thu, Jan 07, 2016 at 09:59:09AM +0100, Michal Privoznik wrote: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1266088 >> >> We are missing this value for cdrom-image device. Honestly, I >> have no idea whether it can happen for other disk devices too. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> src/vmx/vmx.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> > > print(random.choice(famous_last_quotes)) > Shouldn't hurt > > ACK This patch is missing a test case and a corresponding addition to the format function to allow for proper round-trip. I'll propose an improve version later today. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list