On Sun, Jan 10, 2016 at 06:06:20PM -0500, Cole Robinson wrote:
This kills some nested makefiles. They don't hurt much but they are largely redudant so don't serve much usefulness either. After this we have a strict two level Makefile hierarchy, which is an easy rule of thumb to follow. The first two patches clean up blantantly redundant makesfiles Patch 3 is a bit trickier with the wireshark plugin, but it's also more useful to fix since now it can be built in parallel with the rest of the tools/ directory. Cole Robinson (3): build: Kill include/libvirt/Makefile.am build: Kill docs/schemas/Makefile.am build: Kill tools/wireshark Makefiles
ACK to 1 and 2 (with 1 cleaned up according to the comment), but I can't really decide about the last one. We are handling quite a bit of path separators in rule names and that doesn't seem that nice. Anyway, I'm not against it, I would rather someone tested it before ACKing it. And since I can't currently build with wireshark dissector due to some non-compatible changes and me having installed supernew wireshark, so I'll leave it up to Michal^Wsomeone else.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list