On 01/08/2016 02:09 AM, Peter Krempa wrote: > On Thu, Jan 07, 2016 at 22:50:03 -0500, Cole Robinson wrote: >> This also makes VIR_TEST_REGENERATE_OUTPUT work >> --- >> tests/qemuxml2xmltest.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c >> index f967ceb..e3bd9c2 100644 >> --- a/tests/qemuxml2xmltest.c >> +++ b/tests/qemuxml2xmltest.c >> @@ -43,7 +43,7 @@ static int >> testXML2XMLHelper(const char *inxml, >> const char *inXmlData, >> const char *outxml, >> - const char *outXmlData, >> + const char *outXmlData ATTRIBUTE_UNUSED, > > Since there are just two callers of this you might as well as remove > this argument rather than making it unused. > Good point. I dropped this in favor of a bigger cleanup anyways, see just posted patches Thanks, Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list