[PATCH 0/2] Fix problem generating partition names for multipath device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Originally posted as an RFC:

http://www.redhat.com/archives/libvir-list/2015-December/msg00200.html

I've made further adjustments/changes and actually tested in a multipath
environment configured with the issue.

For these patches, rather than making a "general" flag for the pool,
I chose to add an attribute to the <source> 'device'. This way it was
much more clear what the attribute was affecting.

Additionally, it turned out that the issue was showing up for both
'user_friendly_names' and for custom 'alias' name entries in the
/etc/multipath.conf file so rather than being a user_friendly_name
type flag - I just chose to specific state what it was - a way to
not have the partition separator flag "p" added to the generated name.
Also it was a bit more difficult to describe the use of the flag
especially when it was so specific to one backing store type.

John Ferlan (2):
  conf: Add storage pool device attribute part_separator
  storage: Add new flag for libvirt_parthelper

 docs/formatstorage.html.in                         | 30 ++++++++++++++++++++--
 docs/schemas/storagepool.rng                       |  5 ++++
 src/conf/storage_conf.c                            | 26 +++++++++++++++++--
 src/conf/storage_conf.h                            |  3 ++-
 src/storage/parthelper.c                           | 15 ++++++++---
 src/storage/storage_backend_disk.c                 | 11 +++++++-
 .../pool-disk-device-nopartsep.xml                 | 14 ++++++++++
 .../pool-disk-device-nopartsep.xml                 | 14 ++++++++++
 tests/storagepoolxml2xmltest.c                     |  1 +
 9 files changed, 110 insertions(+), 9 deletions(-)
 create mode 100644 tests/storagepoolxml2xmlin/pool-disk-device-nopartsep.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-disk-device-nopartsep.xml

-- 
2.5.0

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]