No only coverity warns about this, but it kind of makes sense too. We have a test whether host supports IOMMU. Some platforms don't have it, I know. But in that case we should print a message that it's unknown whether platform has it or not. Before: (no output) After: QEMU: Checking for device assignment IOMMU support : WARN (Unknown if this platform has IOMMU support) Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> --- tools/virt-host-validate-common.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index dd1c414..8ebf73e 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -367,9 +367,6 @@ int virHostValidateIOMMU(const char *hvname, isIntel = true; else if (virHostValidateHasCPUFlag("svm")) isAMD = true; - else - /* XXX PPC/ARM/etc support */ - return 0; virHostMsgCheck(hvname, "%s", _("for device assignment IOMMU support")); -- 2.4.10 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list