Re: [libvirt-glib][PATCH] libvirt-glib-1.0.pc.in: Correctly mark variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 02, 2016 at 12:46:30PM +0100, Michal Privoznik wrote:
In the pkg-config file for libvirt-glib we have a typo:

 Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@

Noticed the missing '@' after LIBVIRT_LIBS? Well, I just did.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
libvirt-glib-1.0.pc.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


ACK, although it doesn't look like it hurt anyone, ever.  I'm not sure
when Libs.private is used, but I haven't managed to convince pkg-config
to use it or print it anywhere.

diff --git a/libvirt-glib-1.0.pc.in b/libvirt-glib-1.0.pc.in
index 1e8956d..d00be9f 100644
--- a/libvirt-glib-1.0.pc.in
+++ b/libvirt-glib-1.0.pc.in
@@ -8,5 +8,5 @@ Version: @VERSION@
Description: libvirt glib library
Requires: glib-2.0
Libs: -L${libdir} -lvirt-glib-1.0
-Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@
+Libs.private: @LIBVIRT_LIBS@ @GLIB2_LIBS@
Cflags: -I${includedir}/libvirt-glib-1.0 @LIBVIRT_CFLAGS@ @GLIB2_CFLAGS@
--
2.4.10

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]