On Fri, Dec 18, 2015 at 09:04:15AM -0500, John Ferlan wrote: > Commit id '71ce4759' altered the cgroup processing with respect to the > call to virCgroupAddTask being moved out from lower layers into the calling > layers especially for qemu processing of emulator and vcpu threads. The > movement affected lxc insomuch as it is possible for a code path to > return a NULL cgroup *and* a 0 return status via virCgroupNewPartition > failure when virCgroupNewIgnoreError succeeded when virCgroupNewMachineManual > returns. Coverity pointed out that would cause virCgroupAddTask to core. > > This patch will check for a NULL cgroup as well as the negative return > and just return the NULL cgroup to the caller (as it would have previously) > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/lxc/lxc_cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list