Re: [PATCH v2] storage: Attempt to refresh volume after successful wipe volume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12/15/2015 03:03 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1270709
> 
> When a volume wipe is successful, perform a volume refresh afterwards to
> update any volume data that may be used in future volume commands, such as
> volume resize.  For a raw file volume, a wipe could truncate the file and
> a followup volume resize the capacity may fail because the volume target
> allocation isn't updated to reflect the wipe activity.
> 
> Since the documentation doesn't mention this side effect of the zero
> algorithm for a raw file volume, update the various documentation to
> describe the results.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  v1:
>  http://www.redhat.com/archives/libvir-list/2015-December/msg00085.html
> 
>  Changes since v1:
>    * Use the preferred call format from review
>    * Cause error if refreshVol fails
>    * Add wording to docs regarding zero wipe algorithm and truncating
>      the raw file.
> 
>  src/libvirt-storage.c        | 9 +++++++--
>  src/storage/storage_driver.c | 9 ++++++++-
>  tools/virsh.pod              | 5 +++++
>  3 files changed, 20 insertions(+), 3 deletions(-)
> 

As requested reviewed Jan's series, saw his push, adjusted this to just
be the storage_driver.c changes, and pushed.

Tks

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]