[...]
>> static const vshCmdOptDef opts_pool_autostart[] = {
>> - {.name = "pool",
>> - .type = VSH_OT_DATA,
>> - .flags = VSH_OFLAG_REQ,
>> - .help = N_("pool name or uuid")
>> - },
>> + OPT_POOL_COMMON
>> +
>> {.name = "disable",
>> .type = VSH_OT_BOOL,
>> .help = N_("disable autostarting")
>
> Nice. ACK
>
> Should we do something similar to domain, network, ... in the rest of virsh?
>
I think it would make certain things easier - I did remark on this in
the cover letter. It gets a bit tedious to do and review; however, I
think in the long run makes things more consistent. There are a few
options with "slight" differences, but nothing that cannot be worked out.
John
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list