Re: [PATCH v2 07/10] conf: Optionally keep domains with invalid XML, but don't allow starting them

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[...]
>>> +
>>> +        if (virFileReadAll(configFile, 1024*1024*10, &xmlStr) < 0)
>>
>> Any reason to not use MAX_CONFIG_FILE_SIZE?  Cannot imagine this
>> failing, but I mention for consistency
>>
> 
> This was a copy-paste from somewhere else, but I will add
> MAX_CONFIG_FILE_SIZE both here and to that copy-paste source as well (if
> I can find it ;)
> 

Dang it's in a .c file now...  I initially cscope searched on
virFileReadAll... That had some examples... Which is why I mentioned it.

Using 'find src -exec grep "1024.*\*1024.*\*10" {} \;' yields

src/util/virconf.c
src/security/security_apparmor.h

Couldn't say the magic words to cscope to take that string and find
anything though ;-)

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]