[...] > +int > +qemuDomainAttachShmemDevice(virQEMUDriverPtr driver, > + virDomainObjPtr vm, > + virDomainShmemDefPtr shmem) > +{ > + int ret = -1; > + qemuDomainObjPrivatePtr priv = vm->privateData; > + char *devstr = NULL; > + char *charAlias = NULL; Dang... one more thing... why no? if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE)) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("qemu does not support -device")); return -1; } I see it's not in AttachRNG (so why it was missed), *BUT* it is in DetachRNG... So it seems a separate patch for AttachRNG should add that? John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list