Re: [PATCH 1/7] vmware/vmx: use virDomainDefPostParse after parsing vmx config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/12/15 20:30, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Although the commit subject says exactly what the patch does (it adds
virDomainDefPostParse call at the end of vmx parsing routine), it might
be helpful to add a simple note for future reference why this change was
necessary, especially if you'd like to prepare the driver for a bigger
upcoming change/feature.

ACK with a commit message added.

Erik
> ---
>  src/esx/esx_driver.c       | 4 ++--
>  src/vmware/vmware_conf.c   | 3 ++-
>  src/vmware/vmware_driver.c | 2 +-
>  src/vmx/vmx.c              | 5 +++++
>  src/vmx/vmx.h              | 1 +
>  tests/vmx2xmltest.c        | 2 +-
>  6 files changed, 12 insertions(+), 5 deletions(-)
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]