Having looked at the code again there is a wire-ABI incompatible change I think we should make to virtlogd to make it more flexible. Since we've not released 1.3.0 yet, this is the only chance we'll have to change the wire protocol. There are also a couple of fixes in this series we should have before release. Daniel P. Berrange (4): qemu: fix memory leak in opening log file logging: preserve driver, dom name & uuid against log file logging: change log protocol to be more reusable logging: validate flags passed from client in virtlogd src/logging/log_daemon_dispatch.c | 14 ++-- src/logging/log_handler.c | 135 +++++++++++++++++++------------------- src/logging/log_handler.h | 14 ++-- src/logging/log_manager.c | 18 ++--- src/logging/log_manager.h | 9 +-- src/logging/log_protocol.x | 7 +- src/qemu/qemu_domain.c | 47 ++++++------- 7 files changed, 114 insertions(+), 130 deletions(-) -- 2.5.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list