On 01.12.2015 11:33, Martin Kletzander wrote: > virAdmConnect was named after virConnect, but after some discussions, > most of the APIs called will be working with remote daemon and starting > them virAdmDaemon will make more sense. Only possibly controversal name > is CloseCallback (de)registration, and connecting to the daemon (which > will still be Open/Close), but even this makes sense if one thinks about > the daemon being opened and closed, e.g. as file, etc. > > This way all the APIs working with the daemon will start with > virAdmDaemon prefix, they will accept virAdmDaemonPtr as first parameter > and that will better suit with other namings as well (virDomain*, > virAdmServer*, etc.). > > Because in virt-admin, the connection name does not refer to a struct > that would have a connect in its name, also adjust 'connname' in > clients. And because it is not used anywhere in the vsh code, move it > from there into each client. > > Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> > --- > daemon/admin_server.c | 22 ++--- > include/libvirt/libvirt-admin.h | 48 +++++----- > src/admin/admin_protocol.x | 10 +-- > src/admin/admin_remote.c | 36 ++++---- > src/admin_protocol-structs | 10 +-- > src/datatypes.c | 38 ++++---- > src/datatypes.h | 28 +++--- > src/libvirt-admin.c | 195 ++++++++++++++++++++-------------------- > src/libvirt_admin_private.syms | 4 +- > src/libvirt_admin_public.syms | 16 ++-- > src/rpc/gendispatch.pl | 2 +- > tools/virsh.c | 18 ++-- > tools/virsh.h | 1 + > tools/virt-admin.c | 65 +++++++------- > tools/virt-admin.h | 3 +- > tools/vsh.h | 1 - > 16 files changed, 248 insertions(+), 249 deletions(-) ACK Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list