Re: libvirt-php 0.5.1 uneeded files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 30/11/2015 15:56, Michal Privoznik a écrit :
> there's a plenty of other features missing - e.g. docs won't be built with this.

Yes, as I said in my initial email, mostly a PoC.


> I don't know about tests, because I am unable to get this working on
my machine. I mean, this is what I've managed to get to:

phpize / configure / make should be run (for now) in src dir.

Typo fix in attached patch


Remi.

>From 9d031cc96e2a1735bb22e37388b85e03dc00073b Mon Sep 17 00:00:00 2001
From: Remi Collet <fedora@xxxxxxxxxxxxxxxxx>
Date: Mon, 30 Nov 2015 18:57:22 +0100
Subject: [PATCH 4/4] fix typo in config.m4

---
 src/config.m4 |  12 +-

diff --git a/src/config.m4 b/src/config.m4
index d255f77..239329f 100644
--- a/src/config.m4
+++ b/src/config.m4
@@ -1,13 +1,15 @@
 PHP_ARG_WITH(libvirt, for libvirt support,
-[  --with-libvirt             Include varnish support])
+[  --with-libvirt             Include libvirt support])
 
 if test "$PHP_LIBVIRT" != "no"; then
 
   AC_PATH_PROG(PKG_CONFIG, pkg-config, no)
 
-  if test -x "$PKG_CONFIG" && $PKG_CONFIG varnishapi --exists ; then
+  LIBVIRT_REQUIRED=1.2.8
+
+  if test -x "$PKG_CONFIG" && $PKG_CONFIG libvirt --exists ; then
     AC_MSG_CHECKING(libvirt version)
-    if $PKG_CONFIG libvirt --atleast-version=1.2.8 ; then
+    if $PKG_CONFIG libvirt --atleast-version=$LIBVIRT_REQUIRED ; then
       LIBVIRT_INCLUDE=`$PKG_CONFIG libvirt --cflags`
       LIBVIRT_LIBRARY=`$PKG_CONFIG libvirt --libs`
       LIBVIRT_VERSION=`$PKG_CONFIG libvirt --modversion`
@@ -19,7 +21,7 @@ if test "$PHP_LIBVIRT" != "no"; then
     PHP_EVAL_LIBLINE($LIBVIRT_LIBRARY, LIBVIRT_SHARED_LIBADD)
 
     AC_MSG_CHECKING(libvirt-qemu version)
-    if $PKG_CONFIG libvirt-qemu --atleast-version=1.2.8 ; then
+    if $PKG_CONFIG libvirt-qemu --atleast-version=$LIBVIRT_REQUIRED ; then
       QEMU_INCLUDE=`$PKG_CONFIG libvirt-qemu --cflags`
       QEMU_LIBRARY=`$PKG_CONFIG libvirt-qemu --libs`
       QEMU_VERSION=`$PKG_CONFIG libvirt-qemu --modversion`
@@ -31,7 +33,7 @@ if test "$PHP_LIBVIRT" != "no"; then
     PHP_EVAL_LIBLINE($QEMU_LIBRARY, LIBVIRT_SHARED_LIBADD)
 
     AC_MSG_CHECKING(libxml version)
-    if $PKG_CONFIG libxml-2.0 --atleast-version=1.2.8 ; then
+    if $PKG_CONFIG libxml-2.0 --exists ; then
       LIBXML_INCLUDE=`$PKG_CONFIG libxml-2.0 --cflags`
       LIBXML_LIBRARY=`$PKG_CONFIG libxml-2.0 --libs`
       LIBXML_VERSION=`$PKG_CONFIG libxml-2.0 --modversion`
-- 
2.1.0

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]