Re: [PATCH 0/8] qemu: add support for virtio-input devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 27, 2015 at 02:36:09PM +0100, Pavel Hrdina wrote:
On Fri, Nov 20, 2015 at 09:59:35AM +0100, Ján Tomko wrote:
Support virtio-keyboard, virtio-mouse, virtio-tablet and virtio-input-host.

Requires kernel 4.1+ in the guest.

https://www.kraxel.org/blog/2015/06/new-member-in-the-virtio-family-input-devices/
https://bugzilla.redhat.com/show_bug.cgi?id=1231114

Ján Tomko (8):
  qemu: add capabilities for virtio input devices
  conf: parse and format virtio input bus in domain XML
  qemu: build command line for virtio input devices
  qemu: add capability for virtio-input-host-device
  conf: add XML for input device passthrough
  security: label the evdev for input device passthrough
  qemu: add passed-through input devs to cgroup ACL
  qemu: build command line for virtio-input-host device


ACK series.

I have only one thing to mention, but it's not in scope of this series, it's
an existing behavior.  If you define a new guest with mouse/keyboard input
device with bus!=ps2 and graphics is defined, then we always add implicit mouse
and keyboard with bus=ps2 which leads to having two different mouses and
keyboards defined for the guest.  We should probably update the code to not add
any implicit mouse or keyboard if there is already one.


I don't think it's that easy.  We add it to the XML because when we
start QEMU with any graphics, it also automatically gains an
additional mouse and keyboard.  We con't specify it on the command
line, so we're merely trying so that the XML matches what the domain
looks like.

Pavel

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]