Hi Jan On Mon, Nov 23, 2015 at 6:58 PM, Ján Tomko <jtomko@xxxxxxxxxx> wrote: > Overall, the XML looks good to me. Apart from the accel3d attribute, > which is ugly, but less ugly than inveting a separate one. Thanks for your feedback. While reworking the patches and adding xml2xml test, I realized the accel2d/3d is a simple bool, so <model type='virtio' heads='1'> <acceleration accel3d='yes'/> </model> Is turned into: <model type='virtio' heads='1'> <acceleration accel3d='yes' accel2d='no'/> </model> Would it be backward incompatible if we changed it to a tristate? thanks -- Marc-André Lureau -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list