Re: [PATCH 2/6] qemu: query virtio-gpu for virgl support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 20, 2015 at 04:30:41PM +0100, Marc-André Lureau wrote:
> Check if virtio-gpu provides virgl option.
> 

The commit also formats qemu command line.

> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
> ---
>  src/qemu/qemu_capabilities.c                     |  8 ++
>  src/qemu/qemu_capabilities.h                     |  1 +

>  src/qemu/qemu_command.c                          | 15 +++-

The qemuxml2argvtest can be squashed together with the command line
formatter.

>  tests/qemucapabilitiesdata/caps_1.2.2-1.replies  | 22 ++++--
>  tests/qemucapabilitiesdata/caps_1.3.1-1.replies  | 22 ++++--
>  tests/qemucapabilitiesdata/caps_1.4.2-1.replies  | 22 ++++--
>  tests/qemucapabilitiesdata/caps_1.5.3-1.replies  | 22 ++++--
>  tests/qemucapabilitiesdata/caps_1.6.0-1.replies  | 22 ++++--
>  tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 22 ++++--
>  tests/qemucapabilitiesdata/caps_2.1.1-1.replies  | 22 ++++--
>  tests/qemucapabilitiesdata/caps_2.4.0-1.replies  | 95 ++++++++++++++++++++++--
>  11 files changed, 216 insertions(+), 57 deletions(-)

> @@ -1886,6 +1893,7 @@ virQEMUCapsExtractDeviceStr(const char *qemu,
>                           "-device", "vmware-svga,?",
>                           "-device", "qxl,?",
>                           "-device", "qxl-vga,?",
> +                         "-device", "virtio-gpu-pci,?",
>                           NULL);
>      /* qemu -help goes to stdout, but qemu -device ? goes to stderr.  */
>      virCommandSetErrorBuffer(cmd, &output);

This hunk should not be needed; -help parsing is only used for QEMU
older than 1.2.0.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]