Since commit 0c04906fa the check for priv->cgroup doesn't make sense as
the calls to virCgroupHasController return the same information. Remove
it and move it's comment partially to the new check.
The already spurious check was also later copied to the iothreads code.
---
src/qemu/qemu_cgroup.c | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index a8e0b8c..3c7694a 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -998,18 +998,13 @@ qemuSetupCgroupForVcpu(virDomainObjPtr vm)
/*
* If CPU cgroup controller is not initialized here, then we need
* neither period nor quota settings. And if CPUSET controller is
- * not initialized either, then there's nothing to do anyway.
+ * not initialized either, then there's nothing to do anyway. CPU pinning
+ * will be set via virProcessSetAffinity.
*/
if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
return 0;
- /* We are trying to setup cgroups for CPU pinning, which can also be done
- * with virProcessSetAffinity, thus the lack of cgroups is not fatal here.
- */
- if (priv->cgroup == NULL)
- return 0;
-
if (priv->nvcpupids == 0 || priv->vcpupids[0] == vm->pid) {
/* If we don't know VCPU<->PID mapping or all vcpu runs in the same
* thread, we cannot control each vcpu.
@@ -1109,9 +1104,6 @@ qemuSetupCgroupForEmulator(virDomainObjPtr vm)
!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
return 0;
- if (priv->cgroup == NULL)
- return 0; /* Not supported, so claim success */
-
if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
true, &cgroup_emulator) < 0)
goto cleanup;
@@ -1182,12 +1174,6 @@ qemuSetupCgroupForIOThreads(virDomainObjPtr vm)
!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
return 0;
- /* We are trying to setup cgroups for CPU pinning, which can also be done
- * with virProcessSetAffinity, thus the lack of cgroups is not fatal here.
- */
- if (priv->cgroup == NULL)
- return 0;
-
if (virDomainNumatuneGetMode(vm->def->numa, -1, &mem_mode) == 0 &&
mem_mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
--
2.6.2
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list