The checked predicate is a deduction from the following checks:
1) maximum cpu id is checked for every parsed <vcpusched> element
2) the resulting bitmaps are checked for overlaps
3) there has to be at least one cpu per <vcpusched>
>From the above checks we can indeed deduce that if we have one
<vcpusched> element per CPU we will have at most 'maxvcpus' of them.
Drop the explicit check since it's redundant.
---
src/conf/domain_conf.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3c8a926..a744412 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -15224,12 +15224,6 @@ virDomainDefParseXML(xmlDocPtr xml,
goto error;
}
if (n) {
- if (n > def->maxvcpus) {
- virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
- _("too many vcpusched nodes in cputune"));
- goto error;
- }
-
if (VIR_ALLOC_N(def->cputune.vcpusched, n) < 0)
goto error;
def->cputune.nvcpusched = n;
--
2.6.2
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list