On 11/17/2015 04:26 PM, Stefan Berger wrote: > Cole Robinson <crobinso@xxxxxxxxxx> wrote on 11/17/2015 03:55:13 PM: > >> From: Cole Robinson <crobinso@xxxxxxxxxx> >> To: Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>, Stefan Berger/ >> Watson/IBM@IBMUS, libvir-list@xxxxxxxxxx, berrange@xxxxxxxxxx >> Date: 11/17/2015 03:55 PM >> Subject: Re: [PATCH v2] tpm: adapt sysfs cancel path for new TPM driver >> >> On 11/17/2015 03:49 PM, Stefan Berger wrote: >> > On 11/17/2015 02:12 PM, Cole Robinson wrote: >> >> First, thanks for following up on the fedora bugs so quickly! >> >> >> >> On 11/17/2015 10:46 AM, Stefan Berger wrote: >> >>> Adapt the sysfs TPM command cancel path for the TPM driver that >> >>> does not use a miscdevice anymore since Linux 4.0. Support old >> >>> and new paths and check their availability. >> >>> >> >>> Add a mockup for the test cases to avoid the testing for >> >>> availability of the cancel path. >> >>> >> >> I see you sent a qemu patch for a similar change. What's the benefit of >> >> libvirt setting cancel_path if qemu can (and already attempts to)figure it >> >> out? >> > >> > The only benefit is that libvirt is controlling the parameter. >> > >> >> Then IMO we should let qemu handle it and just drop this path handling >> entirely. If there's ever a need to differentiate from qemu's logic or let the >> user override this value then we can add it back without much trouble >> > > Forgot about that: SELinux labeling of that file requires it afaik. > Ah gotchya. Makes sense - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list