On Tue, Nov 17, 2015 at 03:14:50PM +0100, Cédric Bosdonnat wrote: > Add a configure option to disable virt-login-shell build even if lxc is > enabled. > --- > configure.ac | 14 ++++++++++++++ > tools/Makefile.am | 12 ++++++------ > 2 files changed, 20 insertions(+), 6 deletions(-) ACK > > diff --git a/configure.ac b/configure.ac > index f481c50..c766351 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1074,6 +1074,19 @@ if test "$with_lxc" = "yes" ; then > fi > AM_CONDITIONAL([WITH_LXC], [test "$with_lxc" = "yes"]) > > +AC_ARG_WITH([login_shell], > + [AS_HELP_STRING([--with-login-shell], > + [build virt-login-shell @<:@default=yes@:>@])]) > +m4_divert_text([DEFAULTS], [with_login_shell=yes]) > + > +if test "$with_lxc" != "yes" ; then > + with_login_shell="no" > +fi > +if test "$with_login_shell" ; then > + AC_DEFINE_UNQUOTED([WITH_LOGIN_SHELL], 1, [whether virt-login-shell is built]) > +fi > +AM_CONDITIONAL([WITH_LOGIN_SHELL], [test "$with_login_shell" = "yes"]) > + > dnl > dnl Checks for the Parallels driver > dnl > @@ -2974,6 +2987,7 @@ AC_MSG_NOTICE([ Init script: $with_init_script]) > AC_MSG_NOTICE([Char device locks: $with_chrdev_lock_files]) > AC_MSG_NOTICE([ Default Editor: $DEFAULT_EDITOR]) > AC_MSG_NOTICE([ Loader/NVRAM: $with_loader_nvram]) > +AC_MSG_NOTICE([ virt-login-shell: $with_login_shell]) > AC_MSG_NOTICE([]) > AC_MSG_NOTICE([Developer Tools]) > AC_MSG_NOTICE([]) Minor nitpick - can you create an m4/virt-login-shell.m4 to hold the code and just call it from configure.ac Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list