Re: [PATCH] bhyve: monitor: do not override domain's privateData

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Daniel P. Berrange wrote:

> On Wed, Nov 04, 2015 at 06:08:00PM +0300, Roman Bogorodskiy wrote:
> > Current monitor code overrides domain object's privateData, e.g.
> > in virBhyveProcessStart():
> > 
> >   vm->privateData = bhyveMonitorOpen(vm, driver);
> > 
> > where bhyveMonitorPtr() returns bhyveMonitorPtr.
> > 
> > This is not right thing to do, so make bhyveMonitorPtr
> > a part of the bhyveDomainObjPrivate struct and change related code
> > accordingly.
> > ---
> >  src/bhyve/bhyve_domain.h  |  4 ++++
> >  src/bhyve/bhyve_monitor.c | 36 +++++++++++++++++++-----------------
> >  src/bhyve/bhyve_process.c | 11 +++++++----
> >  3 files changed, 30 insertions(+), 21 deletions(-)
> 
> ACK

Pushed, thanks!

Roman Bogorodskiy

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]