Re: [PATCH v2] syntax-check: Add prohibit_space_in_label rule

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2015-11-16 at 15:05 +0100, Martin Kletzander wrote:
> > +# Allow for up to three spaces before the label: this is to avoid running
> > +# into situations where require_space_before_label is not applied, eg. a
> > +# line matching ^[a-zA-Z0-9]+ :$
> > +sc_prohibit_space_in_label:
> > +	@prohibit='^ ? ? ?[_a-zA-Z0-9]+ +:$$'                          \
> 
> I would prefer ' {0,3}' instead of ' ? ? ?', but just for reading
> purposes.  ACK either way

Pushed with the improvement you suggested and a small tweak
to the comment, thanks!

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]