Re: [PATCH v2] gobject: Add wrapper virDomainSetTime()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

>> +    guint settime_flags;
>> +
>> +    g_return_val_if_fail(GVIR_IS_DOMAIN(dom), FALSE);
>> +    g_return_val_if_fail(err == NULL || *err == NULL, FALSE);
>
> I'd keep a g_return_val_if_fail(flags == 0, FALSE);

But doesn't that make G_GNUC_UNUSED declaration wrong then? I think
it's more important to optimize it out rather than ensuring programmer
doesn't pass wrong value by mistake, here.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]