Re: [PATCH 17/24] qemu: Close logfd when closing monitor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 12, 2015 at 19:37:19 +0100, Jiri Denemark wrote:
> Remembering to call qemuMonitorSetDomainLog in the right paths before
> calling qemuProcessStop is annoying and easy to forget. And I already
> forget to do so in commit v1.2.8-52-g0389060: logfd may be leaked if

forgot

> QEMU process dies between Prepare and Finish migration phases.
> 
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
>  src/qemu/qemu_monitor.c | 2 ++
>  src/qemu/qemu_process.c | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)

ACK

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]