Anno domini 2009 Cole Robinson scripsit:
> Cole Robinson wrote:
> > Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached.
> Pushed now.
Nice idea, wrong function though.
See attached patch and please
git pull http://git.rfc2324.org/repositories/libvirt.git 4upstream
Ciao
Max
--
Follow the white penguin.
>From d6aba6d85d1d3812e4bb5a6c0cbbc9c162e0c2c9 Mon Sep 17 00:00:00 2001
From: Maximilian Wilhelm <max@xxxxxxxxxxx>
Date: Wed, 18 Feb 2009 01:53:12 +0100
Subject: [PATCH] Fix compile error in qemu_driver.c / qemudDomainCreate()
The unused attribute fix introduced in
63d11a5acc1fa663f430086fd5082810ece21ff1 [Remove incorrect ATTRIBUTE_UNUSED
usage.] has been applied to the wrong function. This prevents libvirt from
being build. Fix it.
Signed-off-by: Maximilian Wilhelm <max@xxxxxxxxxxx>
---
src/qemu_driver.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index 8bb948a..20d3c0c 100644
--- a/src/qemu_driver.c
+++ b/src/qemu_driver.c
@@ -1911,7 +1911,7 @@ static int qemudNumDomains(virConnectPtr conn) {
}
static virDomainPtr qemudDomainCreate(virConnectPtr conn, const char *xml,
- unsigned int flags) {
+ unsigned int flags ATTRIBUTE_UNUSED) {
struct qemud_driver *driver = conn->privateData;
virDomainDefPtr def;
virDomainObjPtr vm = NULL;
@@ -2883,7 +2883,7 @@ cleanup:
static char *qemudDomainDumpXML(virDomainPtr dom,
- int flags ATTRIBUTE_UNUSED) {
+ int flags) {
struct qemud_driver *driver = dom->conn->privateData;
virDomainObjPtr vm;
char *ret = NULL;
--
1.5.6.5
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list