Re: [PATCH 2/7] qemu: remove all support for kQEMU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/05/2015 12:33 PM, Daniel P. Berrange wrote:
> The kQEMU accelerator was deleted in QEMU 0.12, so we no
> longer need to support it in the QEMU driver.
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/qemu/qemu_capabilities.c | 18 ------------------
>  src/qemu/qemu_capabilities.h |  4 ++--
>  src/qemu/qemu_command.c      | 23 ++---------------------
>  3 files changed, 4 insertions(+), 41 deletions(-)
> 

[...]

> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index b883315..0c3cf66 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -33,7 +33,7 @@
>  /* Internal flags to keep track of qemu command line capabilities */

Should a comment be left here to indicate an "X_" prior to a capability
means that was previously checked for, but no longer needs checking;
however, something must remain in the list due to compat issues.

Just so some kind soul doesn't come along one day and delete those...

John
>  typedef enum {
>      /* 0 */
> -    QEMU_CAPS_KQEMU, /* Whether KQEMU is compiled in */
> +    X_QEMU_CAPS_KQEMU, /* Whether KQEMU is compiled in */
>      QEMU_CAPS_VNC_COLON, /* VNC takes or address + display */
>      QEMU_CAPS_NO_REBOOT, /* Is the -no-reboot flag available */
>      QEMU_CAPS_DRIVE, /* Is the new -drive arg available */
> @@ -86,7 +86,7 @@ typedef enum {
>      QEMU_CAPS_PCI_CONFIGFD, /* pci-assign.configfd */
>      QEMU_CAPS_NODEFCONFIG, /* -nodefconfig */
>      QEMU_CAPS_BOOT_MENU, /* -boot menu=on support */
> -    QEMU_CAPS_ENABLE_KQEMU, /* -enable-kqemu flag */
> +    X_QEMU_CAPS_ENABLE_KQEMU, /* -enable-kqemu flag */
>  
>      /* 40 */
>      QEMU_CAPS_FSDEV, /* -fstype filesystem passthrough */

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]