On Tue, Nov 03, 2015 at 07:18:09PM -0500, John Ferlan wrote: > Rather than "if (virNetDevFeatureAvailable(ifname, &cmd))" change the > success criteria to "if (virNetDevFeatureAvailable(ifname, &cmd) == 1)". > > The called helper returns -1 on failure, 0 on not found, and 1 on found. > Thus a failure was setting bits. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/util/virnetdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > ACK, introduced by commit ac3ed20 which changed the helper's return values without adjusting its callers. Jan
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list