Jim Meyering <jim@xxxxxxxxxxxx> wrote: > Maximilian Wilhelm <max@xxxxxxxxxxx> wrote: >> The 'getVer' fix introducted in 02a72b420670718640d9abf0e07f2b1cca7b4d2b >> breaks compiling libvirt with loadable module support. >> Work around this to get it building again. >> >> Signed-off-by: Maximilian Wilhelm <max@xxxxxxxxxxx> >> --- >> src/libvirt.c | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) ... > > Thanks for the patch. > I note that this link failure happens when you configure > --with-driver-modules. > > As you suggest with the FIXME comment, there's room for > improvement in this area. > For example, with more than one of the various modules, > we'd actually want all of their version strings, not just > the one that happens to be listed last in the code. > Or perhaps, a method to obtain a list of loaded/loadable modules, > and another to query a module for its version string. > ... > However, even with your patch, the latest sources don't link for me. > I get this: > > /c/libvirt/qemud/qemud.c:840: undefined reference to `virDriverLoadModule' > > The patch below fixes that: > >>From 3c6565f6e78e4a0da898248c07a59033aa111ef7 Mon Sep 17 00:00:00 2001 > From: Jim Meyering <meyering@xxxxxxxxxx> > Date: Mon, 16 Feb 2009 12:57:28 +0100 > Subject: [PATCH] Avoid link failure when configured --with-driver-modules > > * qemud/Makefile.am (WITH_DRIVER_MODULES): Link with libvirt_driver.la > and libvirt_util.la. Indent for readability. ... I've pushed both changes. -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list