Cole Robinson <crobinso@xxxxxxxxxx> wrote:
> We weren't properly initializing the monitor fd value in the VM
> definition structure. If qemu failed to start up, this could lead to
> closing stdin, which made all sorts of poo hit the fan. The attached
> patch fixes this.
>
> diff --git a/src/domain_conf.c b/src/domain_conf.c
> index e46bf43..622665c 100644
> --- a/src/domain_conf.c
> +++ b/src/domain_conf.c
> @@ -504,6 +504,7 @@ virDomainObjPtr virDomainAssignDef(virConnectPtr conn,
> domain->state = VIR_DOMAIN_SHUTOFF;
> domain->def = def;
> domain->monitor_watch = -1;
> + domain->monitor = -1;
>
> if (VIR_REALLOC_N(doms->objs, doms->count + 1) < 0) {
> virReportOOMError(conn);
Looks fine, but you know me... I want proof -- and a test ;-)
Do you have a reproducer?
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list