On Wed, Oct 28, 2015 at 01:25:42PM +0000, Zeeshan Ali (Khattak) wrote: > > > > (flags & GVIR_DOMAIN_TIME_SYNC) != 0 to be consistent with the 'flags == > > 0' before. However, shouldn't it be flags & GVIR_DOMAIN_TIME_SYNC == > > GVIR_DOMAIN_TIME_SYNC to be sure we were not passed unknown flags? > > Yeah, that sounds better. Actually, this is not doing what I meant at all ;) should be flags == GVIR_DOMAIN_TIME_SYNC, or flags & ~GVIR_DOMAIN_TIME_SYNC == 0 if we want to make sure we were only passed known flags. Christophe
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list