Re: [PATCH 02/10] conf: Turn targetNode in struct virDomainMemoryDef to signed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/16/2015 08:11 AM, Peter Krempa wrote:
> Later on, we will need to know whether the user specified the target
> node or not. Turn the variable into a signed value. We already treat it
> as signed in various parts of the qemu driver.
> ---
>  src/conf/domain_conf.c | 10 ++++++----
>  src/conf/domain_conf.h |  2 +-
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 

Seeing domaincommon.rng change in patch 8 got me to thinking - should it
change here? That is from unsignedInt to integer. Especially since
you're checking the return value determined < 0.

ACK - with that adjustment.

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]