[PATCH v2 0/9] Introduce virt-admin client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



v1:
 1/9 - ACKed if adjusted
 6/9 - ACKed
 8/9 - ACKed if squashed into 4/9 --> resolves 7/9

v2:
 - double empty line in private.syms is preserved (1/9)
 - adjusted authors of virt-admin modules (2/9)
 - removed unnecessary includes from virt-admin module (2/9)
 - replaced "int" disconnected type for type "bool" (2/9)
 - dropped unused command groups (2/9)
 - removed unnecessary flags and adminControl struct element (2/9)
 - introduction of virAdmConnectIsAlive split separately (3/9)
 - remote version of admin API moved into a separate module (4/9)
 - updated admin_protocol-structs (8/9)
 - removed debugging leftovers from gendispatch.pl (8/9)
 - properly indented if-else conditions in gendispatch.pl (8/9)
 - removed unrelated paragraph, domain references, unsupported
   options from virt-admin.pod and command 'connect' is now
   (hopefully correctly) documented (9/9)
 - introduction of vshAdmCatchDisconnect and introduction of close
   callbacks had to be squashed together due to dependencies both
   ways <-- review 4/9 pointed out dummy NULL close callback which
   should be replaced by something relevant
 - creation of the admin socket is prohibited (until 1.3.0) => testing
   requires the socket to be permitted and created!

Erik Skultety (9):
  libvirt: Export libvirt config getters by moving them to util
  virt-admin: Introduce first working skeleton
  admin: Introduce virAdmConnectIsAlive
  admin: Move remote admin API version to a separate module
  admin: Do not generate remoteAdminConnect{Open,Close}
  admin: Add URI support and introduce virAdmGetDefaultURI
  admin: Add support for connection close callbacks
  admin: Introduce virAdmConnectGetLibVersion
  virt-admin: Provide a man page for virt-admin

 .gitignore                      |   1 +
 daemon/admin_server.c           |   9 +
 daemon/libvirtd.c               |   1 -
 include/libvirt/libvirt-admin.h |  25 ++
 po/POTFILES.in                  |   2 +
 src/admin/admin_protocol.x      |  15 +-
 src/admin/admin_remote.c        | 217 ++++++++++++
 src/admin_protocol-structs      |   4 +
 src/datatypes.c                 |  22 ++
 src/datatypes.h                 |  15 +-
 src/libvirt-admin.c             | 421 +++++++++++++++--------
 src/libvirt.c                   |  55 +--
 src/libvirt_admin_private.syms  |   1 +
 src/libvirt_admin_public.syms   |   5 +
 src/libvirt_private.syms        |   1 +
 src/rpc/gendispatch.pl          |  11 +-
 src/util/virconf.c              |  52 +++
 src/util/virconf.h              |   2 +-
 tools/Makefile.am               |  36 +-
 tools/virt-admin.c              | 737 ++++++++++++++++++++++++++++++++++++++++
 tools/virt-admin.h              |  47 +++
 tools/virt-admin.pod            | 278 +++++++++++++++
 22 files changed, 1747 insertions(+), 210 deletions(-)
 create mode 100644 src/admin/admin_remote.c
 create mode 100644 tools/virt-admin.c
 create mode 100644 tools/virt-admin.h
 create mode 100644 tools/virt-admin.pod

-- 
2.4.3

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]