On 10/15/2015 09:03 PM, Laine Stump wrote:
This loop *really* bothers me, because there is no failsafe to
terminate it if we never get positive notification that DAD has
completed. This would lock up the network driver startup, which would
lock up libvirtd startup. I think we need to decide on what is the
maximum time this could possibly take to complete (maybe it is somehow
based on the number of interfaces? or maybe it doesn't matter...) and
timeout from the loop after the appropriate iterations.
I did not hear about general timeout for this operation. Maybe 5 min,
for example?
Is the "ip" command available on non-linux platforms? I know there is
*a lot* of netlink stuff in there). Aside from that, POSIX_SHELL isn't
even defined, so this code would fail to compile on non-Linux
platforms with IP_PATH defined (and it would fail to compile on
non-Linux with IP_PATH *not* defined, since addrs and count would then
need ATTRIBUTE_UNUSED). Anyway we try to avoid execing external
binaries unless absolutely necessary, so I think it's reasonable to
only have a stub function that says "not supported" in place of this
(very polite but non-working) replacement.
Ok. I wanted to work-around the case if we do not have libnl installed.
Once these 3 issues are dealt with, I think we can (finally) push this.
I'll try to fix it ASAP. Thank you.
--
Your sincerely,
Maxim Perevedentsev
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list