Re: [PATCH v1 10/23] lock_daemon: Switch to wrapper locking functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 12, 2015 at 12:25:55 +0200, Michal Privoznik wrote:
> Lets use wrapper functions virLockDaemonLock and
> virLockDaemonUnlock instead of virMutexLock and virMutexUnlock.
> This has no functional impact, but it's easier to read (at least
> for me).

Actually we removed such helpers in favor of virObjectLock in most
places.

On the other hand, converting a singleton to virObject is a waste of
resources.

> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/locking/lock_daemon.c | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)
> 

Reluctant ACK if you add a 'inline' keyword.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]