Hi Jim, On Fri, Feb 13, 2009 at 07:07:49PM +0100, Jim Meyering wrote: > Sorry I didn't review this sooner, > but I looked just today after you committed it. > > Here's a proposed patch to make it use better types > (always suspect that using "int" is wrong ;-). Agreed. This is basically a straigt copy from qemudReadMonitorOutput. I'll fix things up there too. > Also, shouldn't it handle read failing with EAGAIN? We didn't set O_NONBLOCK. Do we have to when reading from plain file? Cheers, -- Guido -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list