[PATCH 0/4] storage: Add a 'created' boolean for buildVol[From]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In the review of a recent series dealing with a needing to refresh a pool
prior to adding a new volume:

http://www.redhat.com/archives/libvir-list/2015-October/msg00109.html

it was noted that there would be a small timing window possible between
the check and the actual volume creation attempt.  Michal noted that we
could add a 'created' type flag in order to "know" whether the libvirt
API's created the volume or not during their buildVol API.  As these
things usually do, this also morphed into also needing the same boolean
for the buildVolFrom API.

So that's what this series does... Ok mostly, patch 1 doesn't have anything
to do with this, but I saw the anomaly why working my way through the code.

John Ferlan (4):
  storage: Perform some cleanup of calls
  storage: Add created to virFileOpenAs
  storage: Add created to virDirCreate
  storage: Add checks for buildVol create file

 src/libxl/libxl_domain.c               |  3 ++-
 src/libxl/libxl_driver.c               |  3 ++-
 src/qemu/qemu_driver.c                 |  7 +++++--
 src/qemu/qemu_process.c                |  6 +++---
 src/storage/storage_backend.c          | 28 ++++++++++++++++------------
 src/storage/storage_backend.h          |  3 +++
 src/storage/storage_backend_disk.c     |  3 ++-
 src/storage/storage_backend_fs.c       | 22 +++++++++++++++++-----
 src/storage/storage_backend_logical.c  |  3 ++-
 src/storage/storage_backend_rbd.c      |  2 ++
 src/storage/storage_backend_sheepdog.c |  2 ++
 src/storage/storage_driver.c           | 16 +++++++++++-----
 src/util/virfile.c                     | 23 ++++++++++++++++++-----
 src/util/virfile.h                     |  4 ++--
 src/util/virstoragefile.c              |  3 ++-
 15 files changed, 89 insertions(+), 39 deletions(-)

-- 
2.1.0

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]