On Mon, Oct 05, 2015 at 13:01:27 +0200, Peter Krempa wrote: > On Mon, Oct 05, 2015 at 15:30:42 +0530, Prasanna Kumar Kalever wrote: ... > > + int port; > > + int i; > > This won't pass syntax-check. Please make sure that you'll run it before > posting patches. > > > + Here are the problems pointed out by running 'make syntax-check' on this patch: src/qemu/qemu_command.c:3340:cleanup: maint.mk: Top-level labels should be indented by one space cfg.mk:917: recipe for target 'sc_require_space_before_label' failed src/qemu/qemu_command.c:3268: int i; maint.mk: use size_t, not int/unsigned int for loop vars i, j, k cfg.mk:574: recipe for target 'sc_prohibit_int_ijk' failed Whitespace before (semi)colon: src/qemu/qemu_command.c:3290: "i:port", port ? port : QEMU_DEFAULT_GLUSTER_PORT , No whitespace after keyword: src/qemu/qemu_command.c:3476: if(!(json = qemuBuildGlusterDriveJSON(src))) Whitespace after non-keyword: src/qemu/qemu_command.c:3482: if (virAsprintf (&ret, "json:%s", str) < 0) maint.mk: incorrect formatting, see HACKING for rules cfg.mk:1065: recipe for target 'bracket-spacing-check' failed Peter
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list