Re: [PATCH] qemu: Fix dynamic_ownership qemu.conf setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/29/2015 12:46 AM, Martin Kletzander wrote:
> On Mon, Sep 28, 2015 at 07:53:42PM -0400, Cole Robinson wrote:
>> Commit 307fb904 (Sep 10) added a 'privileged' variable when creating
>> the DAC driver:
>>
>> @@ -153,6 +157,7 @@ virSecurityManagerNewDAC(const char *virtDriver,
>>                          bool defaultConfined,
>>                          bool requireConfined,
>>                          bool dynamicOwnership,
>> +                         bool privileged,
>>                          virSecurityManagerDACChownCallback chownCallback)
>>
>> But argument order is mixed up at the caller, swapping dynamicOwnership
>> and privileged values. This corrects the argument order
>>
> 
> I'm pretty sure I noticed this during review. I must've failed to
> inform the author because I see no reply to the patch that caused it.
> 
> ACK and safe for freeze!
> 

Thanks, pushed now

- Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]